apivideo / api.video-flutter-uploader

The official Flutter video uploader for api.video
https://api.video
MIT License
24 stars 2 forks source link

[Bug]: 'lifecycle' hides member of supertype 'LifecycleOwner' and needs 'override' modifier #20

Closed vincentderidder closed 6 days ago

vincentderidder commented 2 months ago

Version

1.2.3

Environment that reproduces the issue

Device: Pixel 6a (Android 14)

Is it reproducible in the example application?

Yes

Reproduction steps

Run the application in debug mode with target Android.

Expected result

The app runs successfully

Actual result

Build fails:

Launching lib/main.dart on Pixel 6a in debug mode...
e: file:///Users/vincentderidder/Documents/GitHub/api.video-flutter-uploader/android/src/main/kotlin/video/api/flutter/uploader/ProxyLifecycleProvider.kt:23:9 'lifecycle' hides member of supertype 'LifecycleOwner' and needs 'override' modifier
e: file:///Users/vincentderidder/Documents/GitHub/api.video-flutter-uploader/android/src/main/kotlin/video/api/flutter/uploader/ProxyLifecycleProvider.kt:75:5 'getLifecycle' overrides nothing

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':video_uploader:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Compilation error. See log for more details

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 45s
Error: Gradle task assembleDebug failed with exit code 1

Exited (1).

Additional context

No response

Relevant logs output

Launching lib/main.dart on Pixel 6a in debug mode...
e: file:///Users/vincentderidder/Documents/GitHub/api.video-flutter-uploader/android/src/main/kotlin/video/api/flutter/uploader/ProxyLifecycleProvider.kt:23:9 'lifecycle' hides member of supertype 'LifecycleOwner' and needs 'override' modifier
e: file:///Users/vincentderidder/Documents/GitHub/api.video-flutter-uploader/android/src/main/kotlin/video/api/flutter/uploader/ProxyLifecycleProvider.kt:75:5 'getLifecycle' overrides nothing

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':video_uploader:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Compilation error. See log for more details

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 45s
Error: Gradle task assembleDebug failed with exit code 1

Exited (1).
ThibaultBee commented 2 months ago

Hi,

I don't really understand why CI and us don't reproduce this compilation issue. According to the logs, I made a fix. Could you try to build the example on the branch: https://github.com/apivideo/api.video-flutter-uploader/pull/21?

vincentderidder commented 2 months ago

Hi,

The example on branch #21 works as expected. Thank you!

caleb654 commented 2 months ago

Any update on when this fix will be pushed as a new version of the package?

ThibaultBee commented 2 months ago

I am going to release the package right now.

ThibaultBee commented 2 months ago

Done. @vincentderidder could you please close this issue as it is resolved now?

ThibaultBee commented 6 days ago

I suppose this issue is resolved. Closing.