search

apjanke / octave-packajoozle

A just-for-fun reworking of GNU Octave's `pkg` tool
GNU General Public License v3.0
4 stars 1 forks source link

Empty package installs?!? #22

Closed apjanke closed 5 years ago

apjanke commented 5 years ago

Waitaminnit, all these package installations are empty.

[~/Library/Application Support/Octave.app/4.4.1/pkg]
$ find .
.
./queueing-1.2.6
./queueing-1.2.6/packinfo
./queueing-1.2.6/packinfo/CITATION
./queueing-1.2.6/packinfo/COPYING
./queueing-1.2.6/packinfo/DESCRIPTION
./queueing-1.2.6/packinfo/NEWS
./queueing-1.2.6/packinfo/INDEX
./financial-0.5.3
./financial-0.5.3/packinfo
./financial-0.5.3/packinfo/COPYING
./financial-0.5.3/packinfo/DESCRIPTION
./financial-0.5.3/packinfo/NEWS
./financial-0.5.3/packinfo/INDEX
./struct-1.0.14
./struct-1.0.14/packinfo
./struct-1.0.14/packinfo/COPYING
./struct-1.0.14/packinfo/DESCRIPTION
./struct-1.0.14/packinfo/NEWS
./struct-1.0.14/packinfo/INDEX
./data-smoothing-1.3.0
./data-smoothing-1.3.0/packinfo
./data-smoothing-1.3.0/packinfo/COPYING
./data-smoothing-1.3.0/packinfo/DESCRIPTION
./data-smoothing-1.3.0/packinfo/NEWS
./struct-1.0.15
./struct-1.0.15/packinfo
./struct-1.0.15/packinfo/COPYING
./struct-1.0.15/packinfo/DESCRIPTION
./struct-1.0.15/packinfo/NEWS
./struct-1.0.15/packinfo/INDEX
./io-2.4.12
./io-2.4.12/PKG_DEL
./io-2.4.12/PKG_ADD
./io-2.4.12/packinfo
./io-2.4.12/packinfo/COPYING
./io-2.4.12/packinfo/DESCRIPTION
./io-2.4.12/packinfo/NEWS
./io-2.4.12/packinfo/INDEX
./statistics-1.4.0
./statistics-1.4.0/packinfo
./statistics-1.4.0/packinfo/COPYING
./statistics-1.4.0/packinfo/DESCRIPTION
./statistics-1.4.0/packinfo/NEWS
./statistics-1.4.0/packinfo/INDEX
./optim-1.5.3
./optim-1.5.3/PKG_ADD
./optim-1.5.3/packinfo
./optim-1.5.3/packinfo/COPYING
./optim-1.5.3/packinfo/DESCRIPTION
./optim-1.5.3/packinfo/NEWS
./optim-1.5.3/packinfo/INDEX
./optics-0.1.3
./optics-0.1.3/packinfo
./optics-0.1.3/packinfo/COPYING
./optics-0.1.3/packinfo/DESCRIPTION
./optics-0.1.3/packinfo/NEWS
./optics-0.1.3/packinfo/INDEX
./splines-1.3.2
./splines-1.3.2/packinfo
./splines-1.3.2/packinfo/CITATION
./splines-1.3.2/packinfo/COPYING
./splines-1.3.2/packinfo/DESCRIPTION
./splines-1.3.2/packinfo/NEWS
./splines-1.3.2/packinfo/INDEX
./data-smoothing-1.2.3
./data-smoothing-1.2.3/packinfo
./data-smoothing-1.2.3/packinfo/COPYING
./data-smoothing-1.2.3/packinfo/DESCRIPTION
./nan-3.1.4
./nan-3.1.4/packinfo
./nan-3.1.4/packinfo/COPYING
./nan-3.1.4/packinfo/DESCRIPTION
./nan-3.1.4/packinfo/NEWS
./nan-3.1.4/packinfo/INDEX
./octave_packages
./strings-1.2.0
./strings-1.2.0/packinfo
./strings-1.2.0/packinfo/COPYING
./strings-1.2.0/packinfo/DESCRIPTION
./strings-1.2.0/packinfo/NEWS
./strings-1.2.0/packinfo/INDEX
./optim-1.5.1
./optim-1.5.1/PKG_ADD
./optim-1.5.1/packinfo
./optim-1.5.1/packinfo/COPYING
./optim-1.5.1/packinfo/DESCRIPTION
./optim-1.5.1/packinfo/NEWS
./optim-1.5.1/packinfo/INDEX
./x86_64-apple-darwin15.6.0-api-v52
./x86_64-apple-darwin15.6.0-api-v52/queueing-1.2.6
./x86_64-apple-darwin15.6.0-api-v52/financial-0.5.3
./x86_64-apple-darwin15.6.0-api-v52/struct-1.0.14
./x86_64-apple-darwin15.6.0-api-v52/data-smoothing-1.3.0
./x86_64-apple-darwin15.6.0-api-v52/struct-1.0.15
./x86_64-apple-darwin15.6.0-api-v52/io-2.4.12
./x86_64-apple-darwin15.6.0-api-v52/statistics-1.4.0
./x86_64-apple-darwin15.6.0-api-v52/statistics-1.4.0/PKG_DEL
./x86_64-apple-darwin15.6.0-api-v52/statistics-1.4.0/PKG_ADD
./x86_64-apple-darwin15.6.0-api-v52/optim-1.5.3
./x86_64-apple-darwin15.6.0-api-v52/optics-0.1.3
./x86_64-apple-darwin15.6.0-api-v52/splines-1.3.2
./x86_64-apple-darwin15.6.0-api-v52/data-smoothing-1.2.3
./x86_64-apple-darwin15.6.0-api-v52/nan-3.1.4
./x86_64-apple-darwin15.6.0-api-v52/strings-1.2.0
./x86_64-apple-darwin15.6.0-api-v52/optim-1.5.1
[~/Library/Application Support/Octave.app/4.4.1/pkg]
$
apjanke commented 5 years ago

Oh, ha ha ha, dirempty () had its test inverted, so it was returning the wrong answer, and nothing was actually getting copied to the real installation directories.

Fixed in https://github.com/apjanke/octave-packajoozle/commit/6dab52a306ac669d5f845c874ad5f27de22a4e0e.