search

apjanke / octave-packajoozle

A just-for-fun reworking of GNU Octave's `pkg` tool
GNU General Public License v3.0
4 stars 1 forks source link

pkj review: check if version num matches filename #41

Closed cbm755 closed 5 years ago

cbm755 commented 5 years ago

Is it reasonable to check if the version number in DESCRIPTION, configure.ac (if present) matches the file name?

apjanke commented 5 years ago

Done in https://github.com/apjanke/octave-packajoozle/commit/87b72c101b79e249b96274aca4a71814b7b8c97f. This verifies that the file name matches the name & version defined in DESCRIPTION.

It's already separately verifying that the version in configure.ac matches the version in DESCRIPTION. It's not checking the name in configure.ac because I found that doesn't match the name in some DESCRIPTIONs, so I didn't know if it was required. Should we require that?

lostbard commented 5 years ago

Currently the check for the configure.ac version requires a space after the command, preceding the version number. AC_INIT([package], [1.0.0]) - will work AC_INIT([package],[1.0.0]) - will say the version doesn't match

apjanke commented 5 years ago

Currently the check for the configure.ac version requires a space after the command, preceding the version number.

Fixed in https://github.com/apjanke/octave-packajoozle/commit/577b42f5ca6605e42c344a9ff9d20b548b0daf20?

lostbard commented 5 years ago

yep that did it!

apjanke commented 5 years ago

Closing as fixed.