Closed mtmiller closed 5 years ago
Ah, packajoozle.internal.PkgReviewer.make_dist_from_repo
does a cd (repo_dir)
to run the make targets, but then later refers to files under repo_dir
.
Three options, do you want to
cd
back after running the make targets?fullfile (repo_dir, …)
?system (sprintf ("make -C %s release", repo_dir))
and let make do the cd'ing?Hmm. I'm getting a different error.
octave:10> pkj review octave-signal -verbose
pkj: review: pkj: reviewing octave-signal
pkj: review: building release from local repo dir
pkj: review: creating distribution tarball from repo at octave-signal
pkj: review: running make dist
abort: cannot archive plain files to stdout
make: *** [-] Error 255
pkj: review: failure: 'make dist' failed. make output:
Creating package version release ...
rm -rf -
hg --config alias.archive=archive --config defaults.archive= archive --exclude ".hg*" --exclude Makefile --type files --rev 2adde4d8b905 -
error: element number 3 undefined in return list
error: called from
review_package_impl at line 171 column 35
review_package at line 60 column 7
pkj>review_package at line 726 column 3
pkj at line 389 column 7
octave:10>
But I see the code you're talking about. I like option 1 best. Once I get this building again, I'll add it in.
Fixed in https://github.com/apjanke/octave-packajoozle/commit/018fcb62cee4adc9b87daf1b35d07e97aeccb1e2.
I took option "2. use relative filenames" because it results in more readable code, IMHO.
I just tried running
pkj review signal
. It went through themake release
target, but then errored out withI will try to test again with a breakpoint set so I can see what's actually going on.