Open apjanke opened 5 years ago
apjanke
commented
5 years ago Oh. One of the error messages for the "review failed" is the "'make release' failed" message, which includes the 'make release' output, which is really long. Ugh. Better truncate that and leave the full output to a captured log file, or something.
apjanke
commented
5 years ago That's also weird that make release for io is apparently doing a make install, too?
apjanke
commented
5 years ago I added a blank line separating the results display from the progress messages that came before it in https://github.com/apjanke/octave-packajoozle/commit/9d546677bde80f132cd70c42139058ebc39134cb. This will make the results more visible in the case like this where there are really long error messages.
After:
octave:4> pkj review octave-io
pkj: review: pkj: reviewing octave-io
pkj: review: creating distribution tarball from repo at octave-io
csvconcat.cc:79:37: warning: result of comparison of constant 18446744073709551615 with expression of type 'unsigned int' is always true
[-Wtautological-constant-out-of-range-compare]
while ((pos=str.find(prot, pos)) != str.npos) {
~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~
1 warning generated.
error: javaaddpath: CLSPATH does not exist: /usr/share/java/xercesImpl-2.11.0.jar
make: *** [target/io-html] Error 1
pkj: review: reviewing io 2.4.12 from file octave-io/target/io-2.4.12.tar.gz
pkj: review: working dir: /var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/packajoozle/pkj-review/work-7Q2UiW
pkj: review: examining distribution file contents
pkj: review: installing under /var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/packajoozle/pkj-review/places/place-T6sSYM
pkj: review: installing package
pkj: build temp dir: /var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/packajoozle/packajoozle-build-io-na4pPH
Installed io 2.4.12 from /var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/packajoozle/pkj-review/work-7Q2UiW/io-2.4.12.tar.gz to tmp-pkj-review pkg dir
For information about changes from previous versions of the io package, run 'news io'.
pkj: review: loading package
pkj: review: unloading package
pkj: unloading: io 2.4.12
pkj: review: uninstalling package
pkj: uninstalling from tmp-pkj-review: io 2.4.12
pkj: packages uninstalled OK
pkj: review: all checks finished
Package review failed for octave-io.
Errors:
'make release' failed. make output:
rm -f -r "target/io-2.4.12"
hg archive --exclude ".hg*" --type files "target/io-2.4.12"
cd "target/io-2.4.12/src" && ./bootstrap && rm -f -r "autom4te.cache"
chmod -R a+rX,u+w,go-w,ug-s "target/io-2.4.12"
tar -c -f - --posix -C "target/" "io-2.4.12" | gzip -9n > "target/io-2.4.12.tar.gz"
Installing package under /Users/janke/tmp/octave-forge/repos/octave-io/target/.installation ...
octave --no-gui --silent --no-history --norc --eval ' llist_path = pkg ("local_list"); mkdir ("/Users/janke/tmp/octave-forge/repos/octave-io/target/.installation"); load (llist_path); local_packages(cellfun (@ (x) strcmp ("io", x.name), local_packages)) = []; save ("/Users/janke/tmp/octave-forge/repos/octave-io/target/.installation/.octave_packages", "local_packages"); pkg ("local_list", "/Users/janke/tmp/octave-forge/repos/octave-io/target/.installation/.octave_packages"); pkg ("prefix", "/Users/janke/tmp/octave-forge/repos/octave-io/target/.installation", "/Users/janke/tmp/octave-forge/repos/octave-io/target/.installation"); pkg ("install", "-local", "-verbose", "target/io-2.4.12.tar.gz"); '
mkdir (/var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/oct-GZUEIm)
untar (target/io-2.4.12.tar.gz, /var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/oct-GZUEIm)
checking for mkoctfile... /usr/local/Cellar/octave/5.1.0/bin/mkoctfile-5.1.0 --verbose
checking for octave-config... /usr/local/Cellar/octave/5.1.0/bin/octave-config-5.1.0
checking whether the C++ compiler works... yes
checking for C++ compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C++ compiler... yes
checking whether clang++ -std=gnu++11 accepts -g... yes
checking how to run the C++ preprocessor... clang++ -std=gnu++11 -E
checking is_numeric_type or isnumeric... isnumeric
checking is_cell or iscell... iscell
checking is_empty or isempty... isempty
configure: creating ./config.status
config.status: creating config.h
/usr/local/Cellar/octave/5.1.0/bin/mkoctfile-5.1.0 --verbose csvexplode.cc
/usr/local/Cellar/octave/5.1.0/bin/mkoctfile-5.1.0 --verbose csv2cell.cc
/usr/local/Cellar/octave/5.1.0/bin/mkoctfile-5.1.0 --verbose csvconcat.cc
/usr/local/Cellar/octave/5.1.0/bin/mkoctfile-5.1.0 --verbose cell2csv.cc
clang++ -std=gnu++11 -c -I/usr/local/opt/qt/include -fPIC -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave/.. -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave -I/usr/local/Cellar/octave/5.1.0/include -D_THREAD_SAFE -pthread -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include/darwin csvexplode.cc -o /var/tmp//oct-LGIquY.o
/usr/local/Cellar/octave/5.1.0/bin/mkoctfile-5.1.0 --verbose col2num.cc
clang++ -std=gnu++11 -c -I/usr/local/opt/qt/include -fPIC -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave/.. -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave -I/usr/local/Cellar/octave/5.1.0/include -D_THREAD_SAFE -pthread -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include/darwin csv2cell.cc -o /var/tmp//oct-k4e8G3.o
/usr/local/Cellar/octave/5.1.0/bin/mkoctfile-5.1.0 --verbose num2col.cc
clang++ -std=gnu++11 -c -I/usr/local/opt/qt/include -fPIC -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave/.. -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave -I/usr/local/Cellar/octave/5.1.0/include -D_THREAD_SAFE -pthread -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include/darwin csvconcat.cc -o /var/tmp//oct-AMVZLU.o
clang++ -std=gnu++11 -c -I/usr/local/opt/qt/include -fPIC -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave/.. -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave -I/usr/local/Cellar/octave/5.1.0/include -D_THREAD_SAFE -pthread -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include/darwin cell2csv.cc -o /var/tmp//oct-ypFP7Z.o
clang++ -std=gnu++11 -c -I/usr/local/opt/qt/include -fPIC -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave/.. -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave -I/usr/local/Cellar/octave/5.1.0/include -D_THREAD_SAFE -pthread -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include/darwin col2num.cc -o /var/tmp//oct-TwhC3V.o
clang++ -std=gnu++11 -c -I/usr/local/opt/qt/include -fPIC -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave/.. -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave -I/usr/local/Cellar/octave/5.1.0/include -D_THREAD_SAFE -pthread -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include/darwin num2col.cc -o /var/tmp//oct-1wF7Qn.o
clang++ -std=gnu++11 -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave/.. -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave -I/usr/local/Cellar/octave/5.1.0/include -D_THREAD_SAFE -pthread -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include/darwin -bundle -bundle_loader /usr/local/Cellar/octave/5.1.0/bin/octave-5.1.0 -F/usr/local/opt/qt/lib -o num2col.oct /var/tmp//oct-1wF7Qn.o -L/usr/local/Cellar/octave/5.1.0/lib/octave/5.1.0 -L/usr/local/Cellar/octave/5.1.0/lib -loctinterp -loctave
clang++ -std=gnu++11 -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave/.. -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave -I/usr/local/Cellar/octave/5.1.0/include -D_THREAD_SAFE -pthread -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include/darwin -bundle -bundle_loader /usr/local/Cellar/octave/5.1.0/bin/octave-5.1.0 -F/usr/local/opt/qt/lib -o col2num.oct /var/tmp//oct-TwhC3V.o -L/usr/local/Cellar/octave/5.1.0/lib/octave/5.1.0 -L/usr/local/Cellar/octave/5.1.0/lib -loctinterp -loctave
clang++ -std=gnu++11 -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave/.. -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave -I/usr/local/Cellar/octave/5.1.0/include -D_THREAD_SAFE -pthread -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include/darwin -bundle -bundle_loader /usr/local/Cellar/octave/5.1.0/bin/octave-5.1.0 -F/usr/local/opt/qt/lib -o csvconcat.oct /var/tmp//oct-AMVZLU.o -L/usr/local/Cellar/octave/5.1.0/lib/octave/5.1.0 -L/usr/local/Cellar/octave/5.1.0/lib -loctinterp -loctave
clang++ -std=gnu++11 -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave/.. -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave -I/usr/local/Cellar/octave/5.1.0/include -D_THREAD_SAFE -pthread -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include/darwin -bundle -bundle_loader /usr/local/Cellar/octave/5.1.0/bin/octave-5.1.0 -F/usr/local/opt/qt/lib -o csvexplode.oct /var/tmp//oct-LGIquY.o -L/usr/local/Cellar/octave/5.1.0/lib/octave/5.1.0 -L/usr/local/Cellar/octave/5.1.0/lib -loctinterp -loctave
clang++ -std=gnu++11 -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave/.. -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave -I/usr/local/Cellar/octave/5.1.0/include -D_THREAD_SAFE -pthread -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include/darwin -bundle -bundle_loader /usr/local/Cellar/octave/5.1.0/bin/octave-5.1.0 -F/usr/local/opt/qt/lib -o cell2csv.oct /var/tmp//oct-ypFP7Z.o -L/usr/local/Cellar/octave/5.1.0/lib/octave/5.1.0 -L/usr/local/Cellar/octave/5.1.0/lib -loctinterp -loctave
clang++ -std=gnu++11 -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave/.. -I/usr/local/Cellar/octave/5.1.0/include/octave-5.1.0/octave -I/usr/local/Cellar/octave/5.1.0/include -D_THREAD_SAFE -pthread -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home/include/darwin -bundle -bundle_loader /usr/local/Cellar/octave/5.1.0/bin/octave-5.1.0 -F/usr/local/opt/qt/lib -o csv2cell.oct /var/tmp//oct-k4e8G3.o -L/usr/local/Cellar/octave/5.1.0/lib/octave/5.1.0 -L/usr/local/Cellar/octave/5.1.0/lib -loctinterp -loctave
copyfile /var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/oct-GZUEIm/io-2.4.12/src/cell2csv.oct /var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/oct-GZUEIm/io-2.4.12/src/col2num.oct /var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/oct-GZUEIm/io-2.4.12/src/csv2cell.oct /var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/oct-GZUEIm/io-2.4.12/src/csvconcat.oct /var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/oct-GZUEIm/io-2.4.12/src/csvexplode.oct /var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/oct-GZUEIm/io-2.4.12/src/num2col.oct /var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/oct-GZUEIm/io-2.4.12/inst/x86_64-apple-darwin18.2.0-api-v53
For information about changes from previous versions of the io package, run 'news io'.
touch /Users/janke/tmp/octave-forge/repos/octave-io/target/.installation/.install_stamp
rm -f -r "target/io-html";
octave --no-gui --silent --no-history --norc --eval ' pkg ("local_list", "/Users/janke/tmp/octave-forge/repos/octave-io/target/.installation/.octave_packages"); ' --eval ' pkg ("load", "io"); ' \
--eval ' pkg load generate_html; ' \
--eval ' javaaddpath ("/usr/share/java/xercesImpl-2.11.0.jar"); ' \
--eval ' javaaddpath ("/usr/share/java/xml-apis.jar"); ' \
--eval 'options = get_html_options ("octave-forge");' \
--eval ' generate_package_html ("io", "target/io-html", options); ';
Version in configure.ac AC_INIT(...) (2.4.10) does not match version in DESCRIPTION (2.4.12)
Warnings:
expected dist file io-2.4.12.tar.gz not created by 'make dist' in root of repo
actual dist file was at target/io-2.4.12.tar.gz
octave:5>
Here's the code for displaying "failed review" results:
But here's what I see when I
pkj review octave-iofrom a local repo. Where's the "Package review failed for" line?