apjanke / octave-tablicious

Table (relational, tabular data) implementation for GNU Octave
https://apjanke.github.io/octave-tablicious/
GNU General Public License v3.0
28 stars 11 forks source link

Compatibility with Octave version 8.x.x #106

Closed ghost closed 5 months ago

ghost commented 11 months ago

Is Tablicious compatible with Octave version 8.2.0 or higher?


Andrew's notes:

TODO

apjanke commented 11 months ago

Hi, praschchoksi!

Tablicious's intent is to support all Octave versions from Octave 6.4.0 up through whatever the current Octave version is. (I should add a note about that to the documentation.)

But I have not actually tested Tablicious under Octave 8.x yet, since I'm still using an older Octave on my personal machines. I'm not aware of anything in particular that would cause major issues under Octave 8.x, but who knows without testing. Especially with Octave's package-management stuff like pkg and PKG_ADD. And I've got these two little things to clean up:

If you encounter any compatibility problems between Tablicious and Octave 8.x (or 7.x for that matter), please post it as an issue here and I'll make it a priority to fix.

Let's leave this ticket open as a reminder to me to get around to testing Tablicious under Octave 8.x. Maybe I'll have time this weekend?

mgcooper commented 10 months ago

@apjanke @prashchoksi

If it's helpful, I'm running 8.3.0 and tablicious appears to work fine. Here's what I did:

That's only a sliver of the functionality, but better than nothing. Happy to help further if you want to provide some tests or a script.

apjanke commented 10 months ago

Thanks, mgcooper!

Happy to help further if you want to provide some tests or a script.

Uhh, writing some more tests, especially some more thorough unit tests, is on my to-do list here. What you ran is what I've got for you at the moment.

Leaving this ticket open until I can play around with Tablicious under Octave 8.x myself and better confirm this. Hopefully with some additional tests.

roger-noss commented 10 months ago

Aside from shadowing warnings by endsWith.m and startsWith.m when installing via 'pkg load -forge tablicious', I encountered:

error: '__event_manager_register_doc__' undefined near line 41, column 7 error: called from load_tablicious at line 41 column 7 C:\Users\roger\AppData\Roaming\octave\api-v58\packages\tablicious-0.3.6\PKG_ADD at line 3 column 1 doc_cache_create>gen_doc_cache_in_dir at line 146 column 5 doc_cache_create at line 62 column 12 install>generate_lookfor_cache at line 840 column 5 install at line 241 column 7 pkg at line 619 column 9

Perhaps it is useful to you. Windows 11, version 8.3.0

apjanke commented 10 months ago

That is useful, roger-noss. Looks like the (semi-documented) API for registering documents with Octave's graphical help browser has changed. Going to have to add in some conditionalization there, I think.

Updating the main description on this ticket with a couple specific TODOs.

apjanke commented 6 months ago

I think this is all fixed on the main branch. (Except for the username-in-spaces thing; that'll be harder.) A Tablicious 0.4.0 release with the fixes will be coming soon.

If you want to test this out ahead of time, you can clone the repo or download a copy of its contents from GitHub, and add its inst/ directory to your Octave path. That should get everything except the datetime time zone conversions working. It's working for me under Octave 8.4.0 on macOS that way.

apjanke commented 5 months ago

Closing this ticket as Fixed since it's all merged to main and seems to be working. If you run in to any further Octave 8.x compatibility problems, feel free to reopen this ticket.