search

apjanke / octave-tablicious

Table (relational, tabular data) implementation for GNU Octave
https://apjanke.github.io/octave-tablicious/
GNU General Public License v3.0
28 stars 11 forks source link

string.m: add plus operator overload #121

Closed reos-rcrozier closed 5 months ago

reos-rcrozier commented 5 months ago

This is an attempt to add a simple overload for the plus operator for the string class which relies entirely on strcat for it's implementation.

apjanke commented 5 months ago

Oops - kind of embarrassing I missed this one! Thanks. I'll review and pull it in.

apjanke commented 5 months ago

Merged! I was in a real hurry to get this in for an 0.4.1 bugfix release, so I pulled it in (with my revisiond) using my local git instead of merging this GitHub PR. I preserved your author credit in the commit.

Merged here: https://github.com/apjanke/octave-tablicious/commit/12ffeaa3230095cc978e1e5d8713a9e16f3e1b87

Thanks! Closing as done.

reos-rcrozier commented 5 months ago

Thanks, I admit I just edited this online and didn't test it, thanks for fixing and incorporating.