search

apjanke / octave-tablicious

Table (relational, tabular data) implementation for GNU Octave
https://apjanke.github.io/octave-tablicious/
GNU General Public License v3.0
28 stars 11 forks source link

+tblish/+internal/mycombvec.m: Fix syntax error #124

Closed mmuetzel closed 5 months ago

mmuetzel commented 5 months ago

Spaces ` separate elements inside brackets[ ]`. So, that line is interpreted as

out = [out; [repmat, (a(i), [size, (rest_combs,1), 1]), rest_combs]];

Combining comma-separated lists with parenthesis is not supported (and is probably not what was intended).

Fix the syntax errorby removing the space between function name and opening parenthesis inside brackets.

See the failing doctest: https://github.com/gnu-octave/packages/pull/401

Andrew's notes

See also: https://github.com/apjanke/octave-tablicious/issues/127

apjanke commented 5 months ago

Oh, shoot; I didn't even see that you had already submitted a PR for this. I'm sorry! I already checked in a fix for this in https://github.com/apjanke/octave-tablicious/commit/151d2eca32f43ced25a6b84c71958a9f61ed692a, which covers this mycombvec issue, and similar ones I found in a few other functions.

Would you mind re-testing against HEAD of main to see if my change took care of things for you?

mmuetzel commented 5 months ago

No worries. I didn't check the codebase. Just reacted on the test error on https://github.com/gnu-octave/packages/pull/401