search

apjanke / octave-tablicious

Table (relational, tabular data) implementation for GNU Octave
https://apjanke.github.io/octave-tablicious/
GNU General Public License v3.0
28 stars 11 forks source link

install tablicious 0.3.5 fails on Octave 7.x #91

Closed geerligs closed 1 year ago

geerligs commented 2 years ago

When trying to install the tablicious package I get some errors:

>> pkg install "https://github.com/apjanke/octave-tablicious/archive/v0.3.6.tar.gz"
warning: function C:\Users\han\AppData\Roaming\octave\api-v57\packages\tablicious-0.3.6\endsWith.m shadows a core libra
ry function
warning: called from
    doc_cache_create>gen_doc_cache_in_dir at line 146 column 5
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5
    install at line 241 column 7
    pkg at line 603 column 9

warning: function C:\Users\han\AppData\Roaming\octave\api-v57\packages\tablicious-0.3.6\startsWith.m shadows a core lib
rary function
warning: called from
    doc_cache_create>gen_doc_cache_in_dir at line 146 column 5
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5
    install at line 241 column 7
    pkg at line 603 column 9

error: '__event_manager_register_doc__' undefined near line 41, column 7
error: called from
    load_tablicious at line 41 column 7
    C:\Users\han\AppData\Roaming\octave\api-v57\packages\tablicious-0.3.6\PKG_ADD at line 3 column 1
    doc_cache_create>gen_doc_cache_in_dir at line 146 column 5
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5
    install at line 241 column 7
    pkg at line 603 column 9

I tried also in admin mode.

Any clues how to solve this?

My ver is:

----------------------------------------------------------------------
GNU Octave Version: 7.1.0 (hg id: 04120d65778a)
GNU Octave License: GNU General Public License
Operating System: MINGW32_NT-6.2 Windows 6.2  x86_64
----------------------------------------------------------------------
Package Name         | Version | Installation directory
---------------------+---------+-----------------------
              audio  |   2.0.4 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\audio-2.0.4
             biosig  |   2.4.0 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\biosig-2.4.0
     communications  |   1.2.4 | ...\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\communications-1.2.4
            control  |   3.4.0 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\control-3.4.0
     data-smoothing  |   1.3.0 | ...\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\data-smoothing-1.3.0
           database  |   2.4.4 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\database-2.4.4
          dataframe  |   1.2.0 | ...\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\dataframe-1.2.0
              dicom  |   0.4.1 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\dicom-0.4.1
          financial  |   0.5.3 | ...\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\financial-0.5.3
               fits  |   1.0.7 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\fits-1.0.7
fuzzy-logic-toolkit  |   0.4.6 | ...\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\fuzzy-logic-toolkit-0.4.6
                 ga  |  0.10.3 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\ga-0.10.3
            general  |   2.1.2 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\general-2.1.2
      generate_html  |   0.3.2 | ...\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\generate_html-0.3.2
           geometry  |   4.0.0 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\geometry-4.0.0
                gsl  |   2.1.1 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\gsl-2.1.1
              image  |  2.14.0 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\image-2.14.0
 instrument-control  |   0.7.1 | ...\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\instrument-control-0.7.1
           interval  |   3.2.1 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\interval-3.2.1
                 io  |   2.6.4 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\io-2.6.4
     linear-algebra  |   2.2.3 | ...\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\linear-algebra-2.2.3
               lssa  |   0.1.4 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\lssa-0.1.4
              ltfat  |   2.3.1 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\ltfat-2.3.1
            mapping  |   1.4.2 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\mapping-1.4.2
            matgeom  |   1.2.3 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\matgeom-1.2.3
      miscellaneous  |   1.3.0 | ...\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\miscellaneous-1.3.0
                nan  |   3.6.1 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\nan-3.6.1
             netcdf  |  1.0.14 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\netcdf-1.0.14
              nurbs  |   1.4.3 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\nurbs-1.4.3
                ocs  |   0.1.5 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\ocs-0.1.5
            octproj  |   2.0.1 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\octproj-2.0.1
              optim  |   1.6.1 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\optim-1.6.1
        optiminterp  |   0.3.7 | ...\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\optiminterp-0.3.7
         quaternion  |   2.4.0 | ...\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\quaternion-2.4.0
           queueing  |   1.2.7 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\queueing-1.2.7
             signal  |   1.4.1 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\signal-1.4.1
            sockets  |   1.3.0 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\sockets-1.3.0
          sparsersb  |   1.0.9 | ...\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\sparsersb-1.0.9
            splines  |   1.3.4 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\splines-1.3.4
         statistics  |   1.4.3 | ...\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\statistics-1.4.3
                stk  |   2.7.0 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\stk-2.7.0
            strings  |   1.2.0 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\strings-1.2.0
             struct  |  1.0.17 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\struct-1.0.17
           symbolic  |   2.9.0 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\symbolic-2.9.0
             tisean  |   0.2.3 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\tisean-0.2.3
                tsa  |   4.6.3 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\tsa-4.6.3
              video  |   2.0.2 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\video-2.0.2
            windows  |   1.6.2 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\windows-1.6.2
             zeromq  |   1.5.3 | D:\Program Files\GNU Octave\Octave-7.1.0\mingw64\share\octave\packages\zeromq-1.5.3
[
apjanke commented 2 years ago

This looks like a problem with Tablicious not being compatible with Octave 7.1.

See this?

error: '__event_manager_register_doc__' undefined near line 41, column 7
error: called from
    load_tablicious at line 41 column 7
    C:\Users\han\AppData\Roaming\octave\api-v57\packages\tablicious-0.3.6\PKG_ADD at line 3 column 1
    doc_cache_create>gen_doc_cache_in_dir at line 146 column 5
    doc_cache_create at line 62 column 12
    install>generate_lookfor_cache at line 840 column 5

That's Tablicious trying to register its interactive documentation stuff with the Octave GUI/IDE (with the whole Qt Help system thing). And it's using - okay, fine, a probably-unsupported undocumented private function to do so. And it looks like this private function has been changed or removed in Octave 7.x.

This is Tablicious's fault: it needs to add support for the Octave 7.x way of doing this. And regardless of that, it should be trapping the help-system registration with a try/catch in its package-loading code so that a failure registering the GUI help stuff doesn't break the whole library-loading process.

Thanks for the bug report! I'll see if I can get to this over this weekend.

geerligs commented 2 years ago

hi Andrew,

thanks for the prompt response. Looking forward to a fix.

--Han

carlosal1015 commented 2 years ago

I reproduce the same issue in Arch Linux with octave 7.1.0-3 and tablicious 0.3.6.

Also, with the last commit b42f860a35aa05140eb1196c3c33b2dfbbeead0d from master.

geerligs commented 2 years ago

Hi Andrew,

any news from the bug-fixing?

regards, Han

gkourachanis commented 2 years ago

Hello! This pull request fixes the issue. It fixes it for me in GNU Octave v7.1.0, tested in Archlinux and Debian Sid.

apjanke commented 2 years ago

Hi y'all! Sorry for the delay in getting this tested & merged. Personal & security-related stuff that I can't really talk about yet. Should get to this soon.

apjanke commented 2 years ago

Okeedoke, I found some time to test the code in the PR. Code looks good; just want to clean up the Git history aspects of the PR before merging and then we're good to go here.

This is a significant enough fix that I'll cut a new release of Tablicious once this PR is merged.