search

apjanke / octave-tablicious

Table (relational, tabular data) implementation for GNU Octave
https://apjanke.github.io/octave-tablicious/
GNU General Public License v3.0
28 stars 11 forks source link

Installation fails in Octave 7.1 for user with space in username #94

Open jrive87 opened 2 years ago

jrive87 commented 2 years ago

I'm trying to install tablicious on Octave 7.1, but I get the following error:

>> pkg install -global "https://github.com/apjanke/octave-tablicious/archive/v0.3.6.tar.gz"
c:/program files/gnu octave/octave-7.1.0/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw3
2/bin/ld.exe: cannot find C:\Users\Test: No such file or directory
c:/program files/gnu octave/octave-7.1.0/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw3
2/bin/ld.exe: cannot find User\AppData\Local\Temp/oct-GO556N.o: No such file or directory
collect2.exe: error: ld returned 1 exit status
make: *** [Makefile:7: __oct_time_binsearch__.oct] Error 1
make: Entering directory '/c/Users/Test User/AppData/Local/Temp/oct-b5ialG/octave-tablicious-0.3.6/src'
C:/PROGRA~1/GNUOCT~1/OCTAVE~1.0/mingw64/bin/mkoctfile-7.1.0.exe __oct_time_binsearch__.cc
make: Leaving directory '/c/Users/Test User/AppData/Local/Temp/oct-b5ialG/octave-tablicious-0.3.6/src'

error: pkg: error running 'make' for the tablicious package
error: called from
    configure_make at line 117 column 9
    install at line 202 column 7
    pkg at line 603 column 9

I suspect the problem is with the computer name, "Test User" --the space between Test and User causing grief. I can't change the name of the laptop. Is there any way around this?

apjanke commented 2 years ago

Your suspicion sounds correct to me.

This is probably something that needs to be fixed with some quoting in the commands run by the installation process. I'm not sure if that's coming from Tablicious's own build scripts (in which case I can fix it here), or is something generated by core Octave (in which case I'll need to pass this along to the main Octave maintainers).

I'll set up a "Test User" on one of my own Windows machines to reproduce this, and see where to go from there.

jrive87 commented 2 years ago

wow, I appreciate the quick attention to this issue. Thank you very much!

lostbard commented 6 months ago

Octave 9 has some changes in it to fix quotation of octave include paths in windows that may help here

https://savannah.gnu.org/bugs/?64609

apjanke commented 6 months ago

Dropping this to Low Priority, since I think user names with a space in them are pretty uncommon. Need to get more core functionality and doco stuff out first.