search

apjanke / octave-testify

New BIST (Built-In Self Test) functions for GNU Octave
GNU General Public License v3.0
4 stars 2 forks source link

BistRunResult:plus has bug with no_tests list #36

Closed cbm755 closed 5 years ago

cbm755 commented 5 years ago

In runtests, it seems that rslts.files_with_no_tests seems to fill up just as rslts.with_tests does. This seems to happen following rslts += rslt;

Is that operation well-defined for structs? Seems... magical.

cbm755 commented 5 years ago

Oh, maybe rslts is an object. In that case, looks like a bug in the plus method?

apjanke commented 5 years ago

rslt isn't a struct; it's a octave.test.internal.BistRunResult object, and BistRunResult provides an overload for plus that does this work.

cbm755 commented 5 years ago

found it, sending silly patch...

apjanke commented 5 years ago

Ahh, I bet I know what your patch is going to be. :)