search

apl-ocean-engineering / sonar_image_proc

Other
12 stars 3 forks source link

Interface cleanup #1

Closed lauralindzey closed 3 years ago

lauralindzey commented 3 years ago

While double-checking that the draw_sonar node works in azimuth-major fashion I noticed that it didn't handle the error case of data_size not in {1,2}.

Seemed worth a quick pull request.

lauralindzey commented 3 years ago

Huh. I'm totally unfamiliar with fips, so I'm not sure why it can't find AbstractSonarInterface.h

Given what changed in this PR, I suspect that the CI breakage predates anything I did.

amarburg commented 3 years ago

Merged in change. Addressed the CI failure separately.