Implement log-scale conversion of 32bit data before rendering

apl-ocean-engineering / sonar_image_proc

Other

12 stars 4 forks source link

Implement log-scale conversion of 32bit data before rendering #18

Closed amarburg closed 2 years ago

amarburg commented 2 years ago

Adds explicit logscale rendering for 32bit data. Also adds ROS dynamic configure hooks to allow changing it on the fly.

amarburg commented 2 years ago

I believe this PR is at least worth picking apart... better than letting it hang out in space for too long

lindzey commented 2 years ago

I took a quick look, but didn't have enough time to give it a thorough review (I'm on my laptop, without any sonar data handy to actually test it) -- however, I'd prefer you go ahead and merge it, rather than having it languish while I'm out. I trust that you've tested that it works, and the new comments do a lot to resolve my earlier concerns about the code structure.

amarburg commented 2 years ago

Merged into main.