Update message defs - Githubissues

apl-ocean-engineering / sonar_image_proc

Other

12 stars 3 forks source link

Update message defs #25

Closed lauralindzey closed 1 year ago

lauralindzey commented 1 year ago

DRAFT. Wait to merge this until all relevant packages are ready.

Converting to match the new acoustic_msgs definitions, which renamed SonarImage -> {Raw,Projected}SonarImage and rearranged fields + metadata representation.

lauralindzey commented 1 year ago

(CI is expected to fail for this because it's building against tag v0.0.1 of hydrographic_msgs.)

lauralindzey commented 1 year ago

I have tested this using a converted bagfile:

rosrun sonar_image_proc draw_sonar_node (visualized in rqt, confirmed not using more CPU than before)
rosrun sonar_image_proc bag2sonar -osd -o output.bag input.bag (visualized output.bag in rqt)
rosrun sonar_image_proc sonar_pointcloud.py (visualized in rviz)

amarburg commented 1 year ago

Thanks. Should update the tag for hydrographic_msgs in the .rosinstall ... need to do this, and it should also fix CI?

lauralindzey commented 1 year ago

Yup, that did the trick! Thanks =)