(dict != "") does not work in java

apla / me.apla.cordova.app-preferences

App preferences plugin for cordova

Apache License 2.0

201 stars 209 forks source link

(dict != "") does not work in java #3

Closed phryneas closed 10 years ago

phryneas commented 10 years ago

this is all over the place in /src/android/AppPreferences.java if (dict != "") is always true, because no string ever will be the same object as "". correct would be if ("".equals(dict))

as all apps currently store keys without a dict as .key, I would suggest you simply remove the check or replace it with if (true) for compatibility.

apla commented 10 years ago

thank you for report! now you can install fixed version 0.4.0 via cordova plugin add me.apla.cordova.app-preferences