search

apla / me.apla.cordova.app-preferences

App preferences plugin for cordova
Apache License 2.0
201 stars 209 forks source link

Added npm dependencies #48

Closed micky2be closed 8 years ago

micky2be commented 9 years ago

To be able to use the generator the node script needs dependencies to be installed.

Review on Reviewable

mgcrea commented 8 years ago

:+1:

SomaticIT commented 8 years ago

Dependencies should not be on the global package, they should be installed only when using plugman. If you want to be able to build without installing any dependencies we need to use hooks.

Take a look at #50.

micky2be commented 8 years ago

You can put it under devDependencies. Like any npm package

SomaticIT commented 8 years ago

Eventually but there are already in file bin/package.json (Source). Only Cordova is missing.

micky2be commented 8 years ago

Which are not installed through a npm install command. I cannot use your modile as a npm dependency.

mgcrea commented 8 years ago

I agree with @micky2be, the module is unusable in it's current state.

apla commented 8 years ago

@mgcrea , @micky2be Sorry about that. Actually most of the things I wanted to implement is in #50, but I very limited in time. I'll hope to fix all things this Sunday and add a Travis job.

apla commented 8 years ago

@mgcrea , @micky2be fixed in 0.7.4 (#53, #55, #57). Please check it out.