Closed orloffv closed 5 years ago
Merging #11 into master will increase coverage by
0.34%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 93.19% 93.53% +0.34%
==========================================
Files 5 5
Lines 294 294
==========================================
+ Hits 274 275 +1
+ Misses 20 19 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/process-db-value.js | 81.57% <0%> (+2.63%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9c0f14e...6b7e94d. Read the comment docs.
I'm sorry:) fixed
@apla check test results without patch - https://travis-ci.org/apla/node-clickhouse/jobs/392865840
/ping
Looks good! One more thing: can you check if CSV/TSV still works for arrays?
Looks good)
@orloffv looks like TSV is not working after this patch. On array ['qwerty'] it fails with an error
Error: Cannot parse input: expected [ before: qwerty\n...
@orloffv looks like TSV is not working after this patch. On array ['qwerty'] it fails with an error
Error: Cannot parse input: expected [ before: qwerty\n...
Yes, actually it doesn't work. Get the same error
Cannot parse input: expected [ before:
Patch changes whitespace characters, can’t see actual changes. Why not to write test for this bug?