search

apla / node-clickhouse

Yandex ClickHouse driver for nodejs
MIT License
216 stars 50 forks source link

Fix confusing auth params #34

Closed nezed closed 5 years ago

nezed commented 5 years ago
  1. Get rid of implicit auth format ( Closes #2 )
  2. Escape symbols as it must be in URI
codecov-io commented 5 years ago

Codecov Report

Merging #34 into master will increase coverage by 0.15%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   87.81%   87.96%   +0.15%     
==========================================
  Files           5        6       +1     
  Lines         320      324       +4     
==========================================
+ Hits          281      285       +4     
  Misses         39       39
Impacted Files Coverage Δ
src/clickhouse.js 96.29% <100%> (+0.06%) :arrow_up:
src/consts.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ecb2f06...256e48f. Read the comment docs.