apla / node-clickhouse

Yandex ClickHouse driver for nodejs
MIT License
216 stars 50 forks source link

Deprecate useless `format` option #36

Open nezed opened 5 years ago

nezed commented 5 years ago

The problem:

Clickhouse understands the FORMAT statement which is accepted for both read (SELECT/DESCRIBE/SHOW/etc) and write (INSERT) kinds of queries.

That means format public option is redundant because we'll always have to parse FORMAT value from query.

For now, we have several issues related to it:

Proposed solution:

@apla are you agree with this solution? I can add deprecation warning to master, for current 1+ releases and create 2.0.0 branch with deprecation.