search

apla / node-clickhouse

Yandex ClickHouse driver for nodejs
MIT License
216 stars 50 forks source link

Add param test, fix formatting (spaces to tabs) #47

Open stereosteve opened 5 years ago

stereosteve commented 5 years ago

related: https://github.com/apla/node-clickhouse/issues/30

codecov-io commented 5 years ago

Codecov Report

Merging #47 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files           6        6           
  Lines         326      326           
=======================================
  Hits          289      289           
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 263e564...81117e5. Read the comment docs.

nezed commented 5 years ago

This is very interesting usage of params. I'll take a closer look and i think it must be presented in README.

I'm not sure is this a good way to implement something like "prepared statements" or "escaped params" because of params implementations in CH HTTP interface.

Also as a part of #37 i'll cleanup codebase soon, so you will be able to push just a usefuls changes 🙃