search

apla / node-clickhouse

Yandex ClickHouse driver for nodejs
MIT License
217 stars 50 forks source link

fix(clickhouse.js): remove encodeURIComponent #57

Closed blastZ closed 4 years ago

blastZ commented 4 years ago

Node http.request method use auth property in options to create base64 Authorization header, so encode will cause error when it includes special characters.

codecov-io commented 4 years ago

Codecov Report

Merging #57 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files           6        6           
  Lines         326      326           
=======================================
  Hits          289      289           
  Misses         37       37
Impacted Files Coverage Δ
src/clickhouse.js 97.56% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 84e195a...4248991. Read the comment docs.

nezed commented 4 years ago

Released in @apla/clickhouse@1.6.2