search

apla / node-clickhouse

Yandex ClickHouse driver for nodejs
MIT License
216 stars 50 forks source link

fix issue #56 #66

Closed evle closed 4 years ago

codecov-commenter commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d660165). Click here to learn what that means. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage          ?   87.46%           
=========================================
  Files             ?        6           
  Lines             ?      327           
  Branches          ?        0           
=========================================
  Hits              ?      286           
  Misses            ?       41           
  Partials          ?        0
Impacted Files Coverage Δ
src/clickhouse.js 97.57% <100.00%> (ø)
src/legacy-support.js 12.00% <0.00%> (ø)
src/streams.js 93.82% <0.00%> (ø)
src/consts.js 100.00% <0.00%> (ø)
src/process-db-value.js 82.05% <0.00%> (ø)
src/parse-error.js 81.25% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d660165...2384959. Read the comment docs.

evle commented 4 years ago

@evle Thank for fixing it! It would be great if you can add test for this case. Please let me know if you need any help or experiencing any problems with it

testcase added

nezed commented 4 years ago

@evle You fix is not available in version @apla/clickhouse@1.6.4

evle commented 4 years ago

@evle You fix is not available in version @apla/clickhouse@1.6.4

is not available? any problems?

nezed commented 4 years ago

@evle Checked it just now - should be ok.

▶ npm logout

▶ npm i @apla/clickhouse@1.6.4
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN test@1.0.0 No description
npm WARN test@1.0.0 No repository field.

+ @apla/clickhouse@1.6.4
added 1 package from 1 contributor and audited 1 package in 0.424s
found 0 vulnerabilities

▶ grep WITH node_modules/@apla/clickhouse/src/clickhouse.js
    if (chQuery.match (/^(?:SELECT|WITH|SHOW|DESC|DESCRIBE|EXISTS\s+TABLE)/i)) {

Can you describe issue that you are experiencing?

evle commented 4 years ago

@evle Checked it just now - should be ok.

▶ npm logout

▶ npm i @apla/clickhouse@1.6.4
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN test@1.0.0 No description
npm WARN test@1.0.0 No repository field.

+ @apla/clickhouse@1.6.4
added 1 package from 1 contributor and audited 1 package in 0.424s
found 0 vulnerabilities

▶ grep WITH node_modules/@apla/clickhouse/src/clickhouse.js
  if (chQuery.match (/^(?:SELECT|WITH|SHOW|DESC|DESCRIBE|EXISTS\s+TABLE)/i)) {

Can you describe issue that you are experiencing?

56