search

apla / node-clickhouse

Yandex ClickHouse driver for nodejs
MIT License
216 stars 50 forks source link

feat: add availability to use HTTPS connection #7

Closed peteychuk closed 6 years ago

peteychuk commented 6 years ago

It would be great to have the ability to uses secure HTTPS connection in order to use this driver for production env.

apla commented 6 years ago

this commit shows precisely how it should be modified to achieve https support: https://github.com/druide/node-clickhouse/commit/f056d979ae8a497efcfdc2d608018a7b8f81839b

codecov-io commented 6 years ago

Codecov Report

Merging #7 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   93.15%   93.19%   +0.04%     
==========================================
  Files           5        5              
  Lines         292      294       +2     
==========================================
+ Hits          272      274       +2     
  Misses         20       20
Impacted Files Coverage Δ
src/clickhouse.js 96.79% <100%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6325455...41f4c6f. Read the comment docs.

peteychuk commented 6 years ago

I've fixed. Using "protocol" instead of a "secure" option.

apla commented 6 years ago

Published

peteychuk commented 6 years ago

Cool, thank you very much. I appreciate so quick publish!