search

aplbrain / bossphorus

A BossDB-like volumetric datastore in Rust
Apache License 2.0
1 stars 1 forks source link

Fix extra cuboid downloads #22

Closed j6k4m8 closed 4 years ago

j6k4m8 commented 4 years ago

...i'm ashamed

j6k4m8 commented 4 years ago

Nope, that wasn't it. Actually.... @movestill — i'm having a hard time getting the same results; i THINK it's just downloading what it needs..?

movestill commented 4 years ago

If I took an empty cache and downloaded less than a cuboid, say 0:128, 0:128, 0:16, I'm pretty sure I saw an extra cuboid in the positive direction along each axis.

I'll try again later. I haven't been able to get myself to do any Rust after hours. Django upgrades having been crushing my soul!

movestill commented 4 years ago

I almost couldn't remember the cargo run command today! :grin:

Looks like rocket isn't building in CI now, though. 😢 Think something changed with the nightly Rust build. CI is configured to use the latest nightly build.

j6k4m8 commented 4 years ago

Yes! Just found out rocket is going to (already does?) work on stable so we can probably increment our rust version dep and remove the nightly requirement!!

On Sat, Aug 1, 2020, 11:48 AM Tim Gion notifications@github.com wrote:

I almost couldn't remember the cargo run command today! 😁

Looks like rocket isn't building in CI now, though. 😢 Think something changed with the nightly Rust build. CI is configured to use the latest nightly build.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aplbrain/bossphorus/pull/22#issuecomment-667550920, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFJKB5JIGO47LBI5PDKIMDR6Q2MDANCNFSM4NEPQ5OQ .

movestill commented 4 years ago

Nice, it’ll be good to switch to stable. IIRC correctly, it was something with macros that required nightly? Need to see if diesel requires nightly. It does some fancy stuff with macros, too.