search

aplbrain / dotmotif

A performant, powerful query framework to search for network motifs
https://bossdb.org/tools/dotmotif
Apache License 2.0
81 stars 9 forks source link

feat: ROI edge constraints for Neuprint Executor (#127) #128

Closed jakobtroidl closed 2 years ago

jakobtroidl commented 2 years ago

Neuprint edge constraints allow ROI specification now. Added functionality to motif_to_cyper in the Neuprint executor.

codecov-commenter commented 2 years ago

Codecov Report

Base: 90.82% // Head: 89.82% // Decreases project coverage by -0.99% :warning:

Coverage data is based on head (827b04d) compared to base (6b178af). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #128 +/- ## ========================================== - Coverage 90.82% 89.82% -1.00% ========================================== Files 23 23 Lines 2256 2281 +25 ========================================== Hits 2049 2049 - Misses 207 232 +25 ``` | [Impacted Files](https://codecov.io/gh/aplbrain/dotmotif/pull/128?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aplbrain) | Coverage Δ | | |---|---|---| | [dotmotif/executors/NeuPrintExecutor.py](https://codecov.io/gh/aplbrain/dotmotif/pull/128/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aplbrain#diff-ZG90bW90aWYvZXhlY3V0b3JzL05ldVByaW50RXhlY3V0b3IucHk=) | `0.00% <0.00%> (ø)` | | | [dotmotif/executors/test\_neuprintexecutor.py](https://codecov.io/gh/aplbrain/dotmotif/pull/128/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aplbrain#diff-ZG90bW90aWYvZXhlY3V0b3JzL3Rlc3RfbmV1cHJpbnRleGVjdXRvci5weQ==) | `14.70% <0.00%> (-6.13%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aplbrain). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aplbrain)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

j6k4m8 commented 2 years ago

All tests are passing! This is an awesome addition, and it looks like it's ready to merge as far as I'm concerned. Is there anything else you want to add before we merge, @jakobtroidl? :)

jakobtroidl commented 2 years ago

All tests are passing! This is an awesome addition, and it looks like it's ready to merge as far as I'm concerned. Is there anything else you want to add before we merge, @jakobtroidl? :)

please go ahead and merge it in :) Thanks, @j6k4m8.