search

aplbrain / dotmotif

A performant, powerful query framework to search for network motifs
https://bossdb.org/tools/dotmotif
Apache License 2.0
81 stars 9 forks source link

fix: weight edge attribute doesn't throw errors anymore (#127) #129

Closed jakobtroidl closed 2 years ago

jakobtroidl commented 2 years ago

The edge attribute in the neuprint executor threw an error with the new JSON feature implementation. I also made the neuprint executor tests more rigorous.

codecov-commenter commented 2 years ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.78%. Comparing base (0003707) to head (e508081). Report is 9 commits behind head on master.

Files Patch % Lines
dotmotif/executors/NeuPrintExecutor.py 0.00% 9 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #129 +/- ## ========================================== - Coverage 89.82% 89.78% -0.04% ========================================== Files 23 23 Lines 2281 2282 +1 ========================================== Hits 2049 2049 - Misses 232 233 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

j6k4m8 commented 2 years ago

Ooh good fix, and thank you for catching + repairing!! Good to merge this?

jakobtroidl commented 2 years ago

Yes, it's ready to merge.