aplbrain / dotmotif

A performant, powerful query framework to search for network motifs
https://bossdb.org/tools/dotmotif
Apache License 2.0
81 stars 9 forks source link

fix: enforce json rules on edge and not on node #130

Closed jakobtroidl closed 2 years ago

jakobtroidl commented 2 years ago

JSON attributes are now mapped to the Neuprint edge objects. Previously, the constraints were incorrectly mapped to node objects.

codecov-commenter commented 2 years ago

Codecov Report

Base: 89.78% // Head: 89.78% // No change to project coverage :thumbsup:

Coverage data is based on head (188c944) compared to base (50515a6). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #130 +/- ## ======================================= Coverage 89.78% 89.78% ======================================= Files 23 23 Lines 2282 2282 ======================================= Hits 2049 2049 Misses 233 233 ``` | [Impacted Files](https://codecov.io/gh/aplbrain/dotmotif/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aplbrain) | Coverage Δ | | |---|---|---| | [dotmotif/executors/NeuPrintExecutor.py](https://codecov.io/gh/aplbrain/dotmotif/pull/130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aplbrain#diff-ZG90bW90aWYvZXhlY3V0b3JzL05ldVByaW50RXhlY3V0b3IucHk=) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aplbrain). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aplbrain)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

j6k4m8 commented 2 years ago

Looks good! Can I merge?

jakobtroidl commented 2 years ago

yes, please merge :)