search

aplbrain / grand

Your favorite Python graph libraries, scalable and interoperable. Graph databases in memory, and familiar graph APIs for cloud databases.
Apache License 2.0
80 stars 6 forks source link

Begin loosening requirements #22

Closed j6k4m8 closed 2 years ago

j6k4m8 commented 2 years ago

Fixes #21

j6k4m8 commented 2 years ago

@AbdealiJK for your awareness, I'm working on #21 here! Feedback welcome.

AbdealiLoKo commented 2 years ago

Just a thought - while doing changes to the GitHub workflow, you may also want to add black for code formatting to keep the syntax styles consistent

Also, in pypi I saw manylinux wheels. But I wasn't clear on why that is the case. Cause grand seems to be a pure python package ... And so, it should not be dependent on OS right ?

EDIT: Ignore my above statement on manylinux. I checked grand instead of grand-graph by mistake. For grand-graph, it may be good to add bdist_wheel and upload wheels directly to pypi as they are being standardized

j6k4m8 commented 2 years ago

Just a thought - while doing changes to the GitHub workflow, you may also want to add black for code formatting to keep the syntax styles consistent

Yes! Probably going to do this in a separate PR so that the inevitable code changes don't get mixed in with the import sorting in this PR.

it may be good to add bdist_wheel and upload wheels directly to pypi as they are being standardized

Agreed!