Closed j6k4m8 closed 2 years ago
@AbdealiJK for your awareness, I'm working on #21 here! Feedback welcome.
Just a thought - while doing changes to the GitHub workflow, you may also want to add black for code formatting to keep the syntax styles consistent
Also, in pypi I saw manylinux wheels. But I wasn't clear on why that is the case. Cause grand seems to be a pure python package ... And so, it should not be dependent on OS right ?
EDIT: Ignore my above statement on manylinux. I checked grand instead of grand-graph by mistake. For grand-graph, it may be good to add bdist_wheel and upload wheels directly to pypi as they are being standardized
Just a thought - while doing changes to the GitHub workflow, you may also want to add black for code formatting to keep the syntax styles consistent
Yes! Probably going to do this in a separate PR so that the inevitable code changes don't get mixed in with the import sorting in this PR.
it may be good to add bdist_wheel and upload wheels directly to pypi as they are being standardized
Agreed!
Fixes #21