search

aplbrain / grand

Your favorite Python graph libraries, scalable and interoperable. Graph databases in memory, and familiar graph APIs for cloud databases.
Apache License 2.0
80 stars 6 forks source link

Fix redundant directedness arguments #36

Closed j6k4m8 closed 2 years ago

j6k4m8 commented 2 years ago

This removes the possibility of doing silly things like

from grand import Graph
from grand.backends import NetworkXBackend

# No longer broken:
Graph(directed=True, backend=NetworkXBackend(directed=False)
codecov-commenter commented 2 years ago

Codecov Report

Merging #36 (152bd21) into master (9950edb) will increase coverage by 0.50%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   71.00%   71.51%   +0.50%     
==========================================
  Files          18       18              
  Lines        1345     1355      +10     
==========================================
+ Hits          955      969      +14     
+ Misses        390      386       -4
Impacted Files Coverage Δ
grand/__init__.py 100.00% <100.00%> (+18.75%) :arrow_up:
grand/dialects/__init__.py 68.32% <100.00%> (+0.39%) :arrow_up:
grand/dialects/test_dialect.py 100.00% <100.00%> (ø)
grand/test_graph.py 100.00% <100.00%> (ø)
grand/backends/_networkx.py 80.00% <0.00%> (+2.50%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9950edb...152bd21. Read the comment docs.