aplbrain / grandiso-networkx

Performant, pure-Python subgraph isomorphism and monomorphism search (aka "motif search")
Apache License 2.0
54 stars 10 forks source link

Created find_motifs_iter to iterate over results #17

Closed Raphtor closed 3 years ago

Raphtor commented 3 years ago

Maintained find_motifs for backward compatibility.

codecov-commenter commented 3 years ago

Codecov Report

Merging #17 (d1d8770) into master (7ee70db) will increase coverage by 0.41%. The diff coverage is 87.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   86.63%   87.05%   +0.41%     
==========================================
  Files           4        4              
  Lines         419      448      +29     
==========================================
+ Hits          363      390      +27     
- Misses         56       58       +2     
Impacted Files Coverage Δ
grandiso/__init__.py 85.71% <75.00%> (-0.62%) :arrow_down:
grandiso/test_grandiso.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ee70db...d1d8770. Read the comment docs.

j6k4m8 commented 3 years ago

This is awesome, and it's going to get us a huge performance bump in a few current bottlenecks!

I pushed two commits to the tail end which:

Take a look and make sure I made everything in the spirit of your PR, and then let's merge!