aleclearmind commented 2 years ago

SimpleQueue has been introduced in Python 3.7. Not sure it's a goal of the project to support Python 3.6, but it seems like easy enough to achieve to be worth it.

codecov-commenter commented 2 years ago

Codecov Report

Merging #30 (981c3e5) into master (322e9e2) will increase coverage by 0.38%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   98.05%   98.43%   +0.38%     
==========================================
  Files           5        4       -1     
  Lines         513      512       -1     
==========================================
+ Hits          503      504       +1     
+ Misses         10        8       -2

Impacted Files	Coverage Δ
grandiso/queues.py	`95.00% <66.66%> (-5.00%)`	:arrow_down:
setup.py

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 322e9e2...981c3e5. Read the comment docs.

j6k4m8 commented 2 years ago

You're right — easy enough! Especially if all I have to do is merge the PR ;) Thank you!!

aleclearmind commented 2 years ago

Sorry to ask for this again, but can we get another release for this? I checked and I think I won't be asking for this again, or if we'll have a similar need in the future we'll just for a private fork waiting for releases with a regular schedule.

j6k4m8 commented 2 years ago

Hi @aleclearmind! Please do give me a nudge if you need a release in the future; I try to stay on top of it but sometimes fall a few commits behind :)

I think that version 2.1.1 on PyPI SHOULD have your changes included; I released it yesterday (21 Dec). Is that one not working?

aplbrain / grandiso-networkx

Python 3.6 support #30

Codecov Report