aplbrain / grandiso-networkx

Performant, pure-Python subgraph isomorphism and monomorphism search (aka "motif search")
Apache License 2.0
52 stars 10 forks source link

DEBUG: Properly update _greatest_backbone_count #37

Closed nobutoba closed 8 months ago

nobutoba commented 8 months ago

The current implementation forgets updating _greatest_backbone_count within the get_next_backbone_candidates() function.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f9be813) 99.27% compared to head (a5165a1) 99.27%.

:exclamation: Current head a5165a1 differs from pull request most recent head dc4589e. Consider uploading reports for the commit dc4589e to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #37 +/- ## ======================================= Coverage 99.27% 99.27% ======================================= Files 4 4 Lines 550 551 +1 ======================================= + Hits 546 547 +1 Misses 4 4 ``` | [Files](https://app.codecov.io/gh/aplbrain/grandiso-networkx/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aplbrain) | Coverage Δ | | |---|---|---| | [grandiso/\_\_init\_\_.py](https://app.codecov.io/gh/aplbrain/grandiso-networkx/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aplbrain#diff-Z3JhbmRpc28vX19pbml0X18ucHk=) | `98.44% <100.00%> (+0.01%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

j6k4m8 commented 8 months ago

AWESOME, thank you for the super attentive catch and bugfix, @nobutoba!! I really appreciate you contributing to the repo :)

nobutoba commented 8 months ago

I'm having fun reading the code. Thank you for the quick response!