search

aplbrain / neuvue-app

MICrONS Proofreading App
Apache License 2.0
1 stars 2 forks source link

Error message #216

Closed hannah-martinez closed 2 years ago

hannah-martinez commented 2 years ago

This error appears at the bottom of the Lineage Viewer, Inspect Task, and Synapse Viewer pages. Possibly others.

image

Raphtor commented 2 years ago

Probably because we're removing the status container's list element in the most recent neuroglancer PR.

Raphtor commented 2 years ago

Perhaps we should change it to setVisible instead of disposeAll?

hannah-martinez commented 2 years ago

I think you're right that this is where the bug was introduced...but I am very confused. The disposeAll function should only be called when the x key is pushed on a neuroglancer page. Why would it induce a bug on a non-neuroglancer page?

setVisible could be a viable alternative but it would require a lot more code. Neuroglancer doesn't store a list of status messages anywhere, so we'd have to implement a mechanism to do that so that we could call setVisible on all of them.

dxenes1 commented 2 years ago

I remember seeing this message before the status hotkey PR. I think its because some of the custom JS written for those pages tries to access the neuroglancer container by the element id: https://github.com/aplbrain/neuvue-app/blob/main/neuvue_project/workspace/static/js/utils.js#L50

This causes the console to log the error:

utils.js:52 Uncaught TypeError: Cannot read properties of null (reading 'style')
    at openSideMenu (utils.js:52:12)
    at app.neuvue.io/:104:3

Which I think neuroglancer listens to and then creates status message for

Raphtor commented 2 years ago

Ah that makes more sense. Lets wrap that so we can avoid errors. Maybe a longer term solution is make NG only listen to its own errors?