search

aplteam / Tatin

Tatin is a package manager for Dyalog APL
MIT License
25 stars 5 forks source link

BuildPackage - build number not recognised properly #123

Closed e9gille closed 1 year ago

e9gille commented 1 year ago

If specifying the build number using a third dot rather than a plus (e.g. 1.2.3.4), it is recognised correctly by the Registry.SplitVersionFromBuild but not by Client.BuildPackage, which appends the build number from the config file (which seems to default to +1).

aplteam commented 1 year ago

Using the dot as a separator was marked as deprecated for several months. Recently this was, as announced, removed.

The documentation states that the build number must be separated from the version number by a + character.

The comments in Registry.SplitVersionFromBuild do not mention the dot as a separator any more.

Is there a really compelling reason to keep supporting the dot as a separator? (I hope not)

e9gille commented 1 year ago

To be honest, I don't think I intended to use a build number at all. Maybe the issue is just that the error message suggested the build number was wrong because I had a third dot: 1.2.3-branch.4 resulted in tatin complaining that 4+1 is not a valid build number. In actual fact the 4 in the end is a pre-release tag and as you say, this is not supported by tatin, so I've changed the format.