search

apluslms / a-plus-design-system

Design System for A+: Guides and Components for A+ design
https://apluslms.github.io/a-plus-design-system/
MIT License
0 stars 2 forks source link

Add documentation on error summary #9

Closed saarasat closed 4 years ago

saarasat commented 4 years ago

Add documentation on validation error summary.

markkuriekkinen commented 4 years ago

This PR seems to be ready and complete, or is there still something under construction? I could merge this.

saarasat commented 4 years ago

This should be ready :) I am going to create the small pr for those bullets in A+ today

mtthwhggns commented 4 years ago

This should be ready :) I am going to create the small pr for those bullets in A+ today

Since the CSS file here will need updating after that, maybe we should keep this PR open until after that?

markkuriekkinen commented 4 years ago

This should be ready :) I am going to create the small pr for those bullets in A+ today

Since the CSS file here will need updating after that, maybe we should keep this PR open until after that?

I'm not yet familiar with how the design-system is implemented. Do we need to copy CSS from a-plus to this design-system so that the examples in the design-system are rendered in the same style as in a-plus, or what is the idea? What kind of CSS needs changes in the design-system?

mtthwhggns commented 4 years ago

I'm not yet familiar with how the design-system is implemented. Do we need to copy CSS from a-plus to this design-system so that the examples in the design-system are rendered in the same style as in a-plus, or what is the idea? What kind of CSS needs changes in the design-system?

For now, CSS changes in aplus cause main.css to be regenerated using SASS. This single file is then manually copied here.

I know this is not ideal, but given we aren't expecting to update this too often, doing it this way seems pretty painless until we can get a proper pipeline going with the assets.