apluslms / a-plus-rst-tools

Tools to publish RST course content for mooc-grader and a-plus. Should be cloned as a course submodule.

MIT License

6 stars 24 forks source link

Fix crash when no exercise URL is set manually #140

Closed ihalaij1 closed 2 years ago

ihalaij1 commented 2 years ago

Description

What?

Fix KeyError (and SphinxError) when no exercise URL was set manually.

Why?

These errors cause the course build to crash.

How?

Fixed the code in abstract_exercise.py and aplus_setup.py

Fixes #139

Testing

What type of test did you run?

[ ] Accessibility test using the WAVE extension.
[ ] Django unit tests.
[ ] Selenium tests.
[ ] Other test. (Add a description below)
[x] Manual testing.

Tested that aplus-manual works with these changes.

Did you test the changes in

[x] Chrome
[ ] Firefox
[ ] This pull request cannot be tested in the browser.

Translation

[ ] Did you modify or add new strings in the user interface? (Read about how to create translation)

Programming style

[x] Did you follow our style guides?
[ ] Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

[ ] documents inside the doc directory.
[ ] README.md.
[ ] Aplus Manual.
[ ] Other documentation (mention below which documentation).

Is it Done?

[ ] Reviewer has finished the code review
[ ] After the review, the developer has made changes accordingly
[ ] Customer/Teacher has accepted the implementation of the feature