apluslms / a-plus-rst-tools

Tools to publish RST course content for mooc-grader and a-plus. Should be cloned as a course submodule.

MIT License

6 stars 24 forks source link

Add min-group-size and max-group-size directive #154

Closed EerikSaksi closed 1 year ago

EerikSaksi commented 1 year ago

Define min-group-size and max-group-size directives in ConfigurableExercise, and add data to Questionnaire and SubmitForm

Fixes #70

Description

What?

Add group size directives

Why?

Before this could only be defined in the config globally

How?

Add group size options to option_spec in ConfigurableExercise, define data in SubmitForm and Questionnaire

Fixes #70

Testing

Remember to add or update unit tests for new features and changes.

How to test your changes in A-plus
How to test accessibility

What type of test did you run?

[ ] Accessibility test using the WAVE extension.
[ ] Django unit tests.
[ ] Selenium tests.
[ ] Other test. (Add a description below)
[ ] Manual testing.

Did you test the changes in

[ ] Chrome
[ ] Firefox
[X] This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

[ ] Did you modify or add new strings in the user interface? (Read about how to create translation)

Programming style

[X] Did you follow our style guides?
[ ] Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

[ ] documents inside the doc directory.
[ ] README.md.
[ ] Aplus Manual.
[ ] Other documentation (mention below which documentation).

Is it Done?

[ ] Reviewer has finished the code review
[ ] After the review, the developer has made changes accordingly
[ ] Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!