apluslms / a-plus

A+ frontend portal - A+ LMS documentation:
https://apluslms.github.io/
Other
67 stars 73 forks source link

Teacher's email notification on submission errors should be sent only when the grading fails to complete after automatic retries #1117

Open markkuriekkinen opened 1 year ago

markkuriekkinen commented 1 year ago

When a student's submission can not be sent to the grader due to some error, the teacher receives an error email notification. However, with the automatic retries of incomplete grading jobs (#1035 and #1060), the notification should be only sent if the grading can not be automatically completed after retries. The teacher should only receive email if he/she should really manually check the situation of the submission.


Old description in Finnish:

Juha S. muistutti, että A+ lähettää (tai pitäisi lähettää) emailia opettajalle, kun tehtävän lataus tai arviointiin lähettäminen epäonnistuvat (kun yhteys pätkii tms.). Jos palautus arvioidaan automaattisesti uudelleen hetken kuluttua (#1035), niin Juha opettajana ei halua turhaan email-ilmoituksia, jos hänen ei tarvitse käsin itse reagoida mitenkään.

Huomioita:

markkuriekkinen commented 1 year ago

@PasiSa was pondering:

Tuota pitää vähän miettiä. Kuinka pitkän yrittelyn jälkeen halutaan lähettää mailia? Ja koska jumiutuneita tehtäviä voi siinä vaiheessa olla useita, niin varmaan halutaan yksi maili per kurssi, tms.?

When could the email be sent? After how long time? Should multiple submission errors be combined in one email?

Note: Juha S. wanted to discuss such details before anything is decided.

jkotimak commented 1 week ago

@jsorva Any new thoughts?

jsorva commented 3 days ago

I guess the main thing is that I’d love to hear the details once there is some kind of plan of what will get implemented. Details such as these:

jsorva commented 3 days ago

Above, it says that "peruskurssilla normaali arviointi valmistuu n. 2 minuutissa". That’s a pretty pessimistic estimate, especially now that our graders (for Scala) are faster than a couple years ago. But yeah, I suppose 2 mins might be something like an upper limit for how long a regular O1 exercise should take in grading.

jsorva commented 3 days ago

Above, it says that "peruskurssilla normaali arviointi valmistuu n. 2 minuutissa". That’s a pretty pessimistic estimate, especially now that our graders (for Scala) are faster than a couple years ago. But yeah, I suppose 2 mins might be something like an upper limit for how long a regular O1 exercise should take in grading.

jsorva commented 3 days ago

Reflecting on this quickly, it seems to me that there are at least five different kinds of assignments that might(?) be treated differently.