apluslms / a-plus

A+ frontend portal - A+ LMS documentation:

https://apluslms.github.io/

Other

67 stars 72 forks source link

Do not add line numbers to extremely long feedback or code #1260

Closed ihalaij1 closed 12 months ago

ihalaij1 commented 1 year ago

Description

What?

Previously, the inspect submission page froze if line numbers were added to extremely long feedback/code. Line numbers are now added only if the feedback or code is shorter than 5000 lines.

A page with ~5000 lines of feedback takes about 3 seconds to load with line numbers.
A page with ~230 000 lines of feedback used to freeze the page. Now it loads fine, but without line numbers.

Fixes #1210

Testing

What type of test did you run?

[ ] Accessibility test using the WAVE extension.
[ ] Django unit tests.
[ ] Selenium tests.
[ ] Other test. (Add a description below)
[x] Manual testing.

Tested that the inspect submission page no longer freezes.

Did you test the changes in

[x] Chrome
[ ] Firefox
[ ] This pull request cannot be tested in the browser.

Translation

[ ] Did you modify or add new strings in the user interface? (Read about how to create translation)

Programming style

[x] Did you follow our style guides?
[ ] Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

[ ] documents inside the doc directory.
[ ] README.md.
[ ] Aplus Manual.
[ ] Other documentation (mention below which documentation).

Is it Done?

[ ] Reviewer has finished the code review
[ ] After the review, the developer has made changes accordingly
[ ] Customer/Teacher has accepted the implementation of the feature