apluslms / a-plus

A+ frontend portal - A+ LMS documentation:

https://apluslms.github.io/

Other

67 stars 72 forks source link

Hide student notifications from hidden course instances #1265

Closed ihalaij1 closed 12 months ago

ihalaij1 commented 1 year ago

Description

What?

Notifications could previously come from hidden course instances, which made it impossible to clear the notification icon due to CourseVisiblePermission.

This is now fixed by filtering courses that are not visible to students and invalidating the CachedNotifications when a course instance is made hidden.

Fixes #683

Testing

What type of test did you run?

[ ] Accessibility test using the WAVE extension.
[ ] Django unit tests.
[ ] Selenium tests.
[ ] Other test. (Add a description below)
[x] Manual testing.

Tested that a student no longer sees notifications from hidden courses.

Did you test the changes in

[x] Chrome
[ ] Firefox
[ ] This pull request cannot be tested in the browser.

Translation

[ ] Did you modify or add new strings in the user interface? (Read about how to create translation)

Programming style

[x] Did you follow our style guides?
[ ] Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

[ ] documents inside the doc directory.
[ ] README.md.
[ ] Aplus Manual.
[ ] Other documentation (mention below which documentation).

Is it Done?

[ ] Reviewer has finished the code review
[ ] After the review, the developer has made changes accordingly
[ ] Customer/Teacher has accepted the implementation of the feature