search

apluslms / a-plus

A+ frontend portal - A+ LMS documentation:
https://apluslms.github.io/
Other
67 stars 72 forks source link

Teacher-facing UI message is technically incorrect in the Inspect view #1269

Closed jsorva closed 9 months ago

jsorva commented 12 months ago

This is a small thing, but anyway.

As illustrated below, the Inspect view may claim that there are higher-scoring submissions, even though there aren’t.

image

markkuriekkinen commented 12 months ago

But there are higher-scoring submissions! You have selected a submission in the unofficial status, thus its score (zero) is not any higher than the score of the other submissions in the ready status. Since unofficial submissions do not affect grading, their score is always zero despite the points that the grader awards them.

jsorva commented 12 months ago

But there are higher-scoring submissions! You have selected a submission in the unofficial status, thus its score (zero) is not any higher than the score of the other submissions in the ready status. Since unofficial submissions do not affect grading, their score is always zero despite the points that the grader awards them.

OK, I suppose that’s one way to interpret things. But I’d argue that the phrasing is not very clear, even if I try to interpret it generously. Also, the literal meaning of the message (~ "There are higher-scoring submissions") is wrong, since there is no submission that scores any higher. IMO, the message should still be changed.

(But yeah, there are more important things to worry about. I won’t belabor the point.)

markkuriekkinen commented 12 months ago

OK, i opened the issue again. This issue is about changing the message so that it is easier to understand the intended meaning.

PasiSa commented 10 months ago

Muskaan is starting to look at this as her first issue. @jsorva would this be better: "Another submission determines the grade for this assignment." (and in Finnish: "Toinen palautus määrittää tämän tehtävän arvosanan.")? Or any other proposals?

jsorva commented 10 months ago

Muskaan is starting to look at this as her first issue. @jsorva would this be better: "Another submission determines the grade for this assignment." (and in Finnish: "Toinen palautus määrittää tämän tehtävän arvosanan.")? Or any other proposals?

I’m assuming that this is a generic message that gets shown both when 1) there actually is a higher-scoring submission and 2) the unofficial-submission scenario that I depicted above. If so, then your suggestion is OK by me.

(Even better messages could be shown if those two two scenarios were dealt with separately, but I suppose there’s no pressing need to do that.)