apluslms / a-plus

A+ frontend portal - A+ LMS documentation:

https://apluslms.github.io/

Other

65 stars 72 forks source link

Change null to mdash on empty student ids in the All results table #1284

Closed ashi006 closed 10 months ago

ashi006 commented 10 months ago

Description

What?

Empty students IDs were displayed as null in the All results table

How?

Replace null with an em dash (—) for a user friendly view

Fixes #1272

Testing

Remember to add or update unit tests for new features and changes.

How to test your changes in A-plus
How to test accessibility

What type of test did you run?

[ ] Accessibility test using the WAVE extension.
[ ] Django unit tests.
[ ] Selenium tests.
[ ] Other test. (Add a description below)
[x] Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

[x] Chrome
[x] Firefox
[ ] This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

[ ] Did you modify or add new strings in the user interface? (Read about how to create translation)

Programming style

[x] Did you follow our style guides?
[ ] Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

[ ] documents inside the doc directory.
[ ] README.md.
[ ] Aplus Manual.
[ ] Other documentation (mention below which documentation).

Is it Done?

[ ] Reviewer has finished the code review
[ ] After the review, the developer has made changes accordingly
[ ] Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

markkuriekkinen commented 10 months ago

Once you have defined a better git commit message, you can also modify the pull request title. The pull request title is also not good.