apluslms / a-plus

A+ frontend portal - A+ LMS documentation:
https://apluslms.github.io/
Other
65 stars 72 forks source link

Add scroll separately button for submitted files on inspect page #1286

Closed ihalaij1 closed 9 months ago

ihalaij1 commented 10 months ago

Description

What?

image

Fixes #1281 Fixes #1111 Closes #1172

Testing

What type of test did you run?

Tested that loading long template files, model files, submitted files, and feedback works correctly.

Did you test the changes in

Translation

Programming style

Have you updated the README or other relevant documentation?

Is it Done?

markkuriekkinen commented 10 months ago

@ihalaij1 There is some confusion here.

ihalaij1 commented 10 months ago

I separated the word wrap button fix to a separate commit.

I will have to check a few more things about the separate scrolling, because this PR does not support scrolling HTML feedback separately.

markkuriekkinen commented 10 months ago

I already manually merged the commit for the "word wrap button" fix (#1281).

markkuriekkinen commented 10 months ago

I already manually merged the commit for the "word wrap button" fix (#1281).

I am also going to merge the commit for the "load more lines" button ("Load long feedback and submission/template/model files in chunks"), but I didn't finish my testing yet. The code looks good in that commit. After these manual merges, this pull request could focus on the "scroll separately" button in the "inspect submission" view and you could rename the pull request (title).

markkuriekkinen commented 10 months ago

Now I have manually added the git commit of the "load more lines" button to the master branch as well as the v1.20_stable branch.

ihalaij1 commented 10 months ago

I have made more changes, the remainder of the PR is now ready for a review @Mankro.