apluslms / a-plus

A+ frontend portal - A+ LMS documentation:
https://apluslms.github.io/
Other
65 stars 72 forks source link

Courses with long name do not display properly on small screens #1292

Closed ashi006 closed 9 months ago

ashi006 commented 10 months ago

Fixes #786

Description

What?

In the header bar, courses with long name were not being displayed properly on smaller screens

How?

Modified the css in _header.scss to set the text-overflow property with other properties to keep everything in the header in one line.

Fixes #786

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

Think of what is affected by these changes and could become broken

Translation

Programming style

Have you updated the README or other relevant documentation?

Is it Done?

Clean up your git commit history before submitting the pull request!

ihalaij1 commented 9 months ago

I still noticed some problems, I ended up looking at the problem myself and found a decent fix by using viewport width percentages (vw) for max-width.

I pushed the changes. I think this PR is ready to be merged.