apluslms / a-plus

A+ frontend portal - A+ LMS documentation:
https://apluslms.github.io/
Other
65 stars 72 forks source link

A+ LTI Tool v1.3: A+ sends unofficial points to the LTI Platform as if they were normal, accepted points #1294

Open markkuriekkinen opened 10 months ago

markkuriekkinen commented 10 months ago

When using A+ as LTI Tool v1.3, if a student makes an unofficial submission (e.g., after the deadline), A+ sends the points to the LTI Platform (like Moodle) gradebook as if they were normal points. However, unofficial points should not affect grading, thus the LTI Platform should only receive zero points from unofficial submissions.

The send_lti_points() function doesn't seem to check the submission status at all, thus it only picks the points from it (even if the submission is unofficial). https://github.com/apluslms/a-plus/blob/47d2f5cc98c571948e0d6f3415d0a7e066319efa/lti_tool/utils.py#L69