apluslms / a-plus

A+ frontend portal - A+ LMS documentation:
https://apluslms.github.io/
Other
65 stars 72 forks source link

The module search under add deadline deviations is case sensitive #1295

Closed ashi006 closed 9 months ago

ashi006 commented 10 months ago

Fixes #1280

Description

What?

In add deadline deviations form, the module field search was case sensitive.

Why?

getSearchResults(() function in ajax_search_select.js was using the default :contains (which is case sensitive) selector to select the module value.

How?

Defined a custom selector "icontains" in ajax_search_results.js file to select elements that contain a specific text substring, case-insensitively and replaced :contains with :icontains in getSearchResults().

Fixes #1280

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

Think of what is affected by these changes and could become broken

Translation

Programming style

Have you updated the README or other relevant documentation?

Is it Done?

Clean up your git commit history before submitting the pull request!

ihalaij1 commented 9 months ago

Great, thank you!

ihalaij1 commented 9 months ago

I updated the commit message to include an empty newline before the Fixes #1280.