apluslms / a-plus

A+ frontend portal - A+ LMS documentation:
https://apluslms.github.io/
Other
65 stars 72 forks source link

Hide module model answers on lifesupport #1330

Closed Mikael-Lenander closed 2 months ago

Mikael-Lenander commented 7 months ago

Description

What?

Now also chapters that are marked as model answers for a module are hidden after the lifesupport time passes.

Why?

Model answers should be hidden after the course ends.

Should the message in the info tooltip inside a hidden chapter MODULE_MODEL_ANSWER_NOT_VISIBLE also be changed accordingly? Now it only says: "This chapter is hidden, since it contains model answers that have not been published yet." even if the course is ended.

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

Student wasn't able to see model chapters after setting lifesupport time to a past date.

Did you test the changes in

Translation

Programming style

Have you updated the README or other relevant documentation?

Is it Done?

Clean up your git commit history before submitting the pull request!

murhum1 commented 2 months ago

I had to rework the way the visibility is checked due to the larger cache rework that was made earlier, but kept the added tests.