apluslms / a-plus

A+ frontend portal - A+ LMS documentation:
https://apluslms.github.io/
Other
64 stars 72 forks source link

check_submission_allowed messages all have the same severity #1343

Closed khattam2 closed 3 months ago

khattam2 commented 4 months ago

Fixes #1226

Description

What?

check_submission_allowed messages all have the same severity

Why?

submission_check is given a flag whether it should print the strings as errors or warnings but this does not make sense

How?

The flag has been removed and severity is decided by the statement.

Testing

image

Remember to add or update unit tests for new features and changes.

What type of test did you run?

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

Think of what is affected by these changes and could become broken

Translation

Programming style

Have you updated the README or other relevant documentation?

Is it Done?

Clean up your git commit history before submitting the pull request!

ihalaij1 commented 3 months ago

This PR requires some more changes to correctly classify and display error/warning/info messages from functions one_has_submissions() and one_has_access().

I will be making these changes myself.