Update to Jutut that a feedback response has been read

[Mikael-Lenander]

Description

What?

Sends an update to Jutut when a student has read a feedback response.

Why?

For urgent messages, teachers need to know whether the student has read the message.

How?

Send a post request to Jutut endpoint /feedback/ that is responsible for creating and updating Feedback instances based on feedback submissions in A+. Adds an attribute to Submission serializer that indicates whether there are unread feedback responses for that (feedback) submission.

Fixes https://github.com/apluslms/mooc-jutut/issues/40.

Has to be merged with https://github.com/apluslms/mooc-jutut/pull/105.

Testing

Remember to add or update unit tests for new features and changes.

• How to test your changes in A-plus
• How to test accessibility

What type of test did you run?

• [ ] Accessibility test using the WAVE extension.
• [x] Django unit tests.
• [ ] Selenium tests.
• [ ] Other test. (Add a description below)
• [x] Manual testing.

Logged in with student and root. Sent a feedback with student and responded to it through Jutut with root. Opened the response notification in A+ and checked that the ok-icon appeared in Jutut. Same test on multiple feedbacks to the same assignment and on editing the response message.

Did you test the changes in

• [ ] Chrome
• [x] Firefox
• [ ] This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

• [ ] Did you modify or add new strings in the user interface? (Read about how to create translation)

Programming style

• [x] Did you follow our style guides?
• [ ] Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

• [ ] documents inside the doc directory.
• [ ] README.md.
• [ ] Aplus Manual.
• [ ] Other documentation (mention below which documentation).

Is it Done?

• [ ] Reviewer has finished the code review
• [ ] After the review, the developer has made changes accordingly
• [ ] Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

[etanttila]

Small style nitpicks: Docstrings should begin right after the first triple quotes (no newline) A comma after the 'feedback_response_seen' would be nice

And speaking of docstrings, I also forgot to mention that "for long blocks of text (such as docstrings and comments), aim to keep the line length under 72 characters to make the text more readable for humans by limiting the column width" (from our styleguide), currently the line lengths are too long (over 100 chars).

[jsorva]

I also shortened the docstring lines to under 72 although I've always used 119 as the max line length myself. (It is easier to follow one length instead of multiple. I don't know why our style guide recommends using 72, 79, and 119)

I’m all for following team style guides.

Had I a vote, I’d vote—if those three are the options in 2024—for 119. Something approx. halfway between 79 and 119 would also feel right.

I don’t know where those three numbers came from. Presumably some Python conventions that I’m unaware of (which would be most of Python conventions).

(Not a team member. Just shouting from the sidelines.)