apluslms / a-plus

A+ frontend portal - A+ LMS documentation:
https://apluslms.github.io/
Other
64 stars 72 forks source link

Fix api endpoint for list of points #1372

Closed mikaelGusse closed 1 month ago

mikaelGusse commented 1 month ago

Description

What?

Fix issue where api endpoint GET /courses//points/ was showing the same list as GET /courses//students/. Now endpoint GET /courses//points/ gives the user a list of all students in a course and their points in the course.

Why?

Allows for easier parsing of points for Aalto Grades.

How?

Changed which list is given to the listserializer

Fixes #1360

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

Think of what is affected by these changes and could become broken

Translation

Programming style

Have you updated the README or other relevant documentation?

Is it Done?

Clean up your git commit history before submitting the pull request!

ihalaij1 commented 1 month ago

Wow!

Interesting find, I wonder if changing the points API to not be the same as the students API will cause issues for some users that currently use the API endpoint...